Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the connection established flag as it should not be necessary.
Deleting the client instance from the
onDisconnect
callback is now supported.NimBLEDevice::deleteClient
no longer blocks tasksAdds a new
Config
struct toNimBLEClient
to efficiently set single bit config settings.Adds
NimBLEClient::setSelfDelete
that takes the bool parametersdeleteOnDisconnect
anddeleteOnConnectFail
This will configure the client to delete itself when disconnected or the connection attempt fails.
Adds
NimBLEClient::setConfig
andNimBLEClient::getConfig
which takes or returns aNimBLEClient::Config
object respectively.Reword
BLE_HS_EAPP
error string to be more accurate.Replaces
NimBLEDevice::setConnectionInProgress
andNimBLEDevice::isConnectionInProgress()
with lower level checks to avoid potential incorrect state reporting.NimBLEClient::connect
will instead callNimBLEScan::stop
if it stopped the scan to release any resources waiting, the call the callback if set.